Adding IAM permissions for new Firehose stream #35942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjordan
approved these changes
Jul 22, 2020
aws/cloudformation/iam.yml.erb
Outdated
| @@ -203,6 +203,7 @@ Resources: | |||
| Resource: | |||
| # TODO provide this ARN through a CloudFormation stack output resource reference. | |||
| - !Sub "arn:aws:firehose:${AWS::Region}:${AWS::AccountId}:deliverystream/analysis-events" | |||
| - !Sub "arn:aws:firehose:${AWS::Region}:${AWS::AccountId}:deliverystream/i18n-string-tracking-events" | |||
There was a problem hiding this comment.
I think this Role resource is used by an old/obsolete Lambda function and doesn't need to be updated, (but wouldn't do any harm to do so either).
| Resource: !Sub "arn:aws:firehose:${AWS::Region}:${AWS::AccountId}:deliverystream/analysis-events" | ||
| Resource: | ||
| - !Sub "arn:aws:firehose:${AWS::Region}:${AWS::AccountId}:deliverystream/analysis-events" | ||
| - !Sub "arn:aws:firehose:${AWS::Region}:${AWS::AccountId}:deliverystream/i18n-string-tracking-events" |
There was a problem hiding this comment.
(Noting the TODO above) ideally we would create this delivery stream as a resource in the application stack and add a stack reference to the resource's ARN directly, but if it's already been manually created it's fine to just make a manual reference here to unblock this work and we can follow up on importing the resource later.
daynew
force-pushed
the
update-iam-with-i18n-stream
branch
from
c3bf6cf
to
ab2a7ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the new Firehose stream to our IAM permissions list. This stream supports the new i18n String : URL tracking feature.
Links
Testing story
deliverystream/analysis-eventsReviewer Checklist: