create unit_groups table, identical to courses table #35949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
force-pushed
the
create-unit-groups-table
branch
from
a0a5efa
to
336492e
Compare
davidsbailey
commented
Jul 24, 2020
Comment on lines
+3
to
+5
| # create unit_groups as an exact copy of the courses table | ||
| execute 'CREATE TABLE unit_groups LIKE courses' | ||
| execute 'INSERT INTO unit_groups SELECT * FROM courses' |
There was a problem hiding this comment.
This strategy was borrowed from https://stackoverflow.com/questions/3280006/duplicating-a-mysql-table-indices-and-data/3280042#3280042
Comment on lines
+24
to
+26
| def remove_foreign_key_if_exists(table, key) | ||
| remove_foreign_key table, column: key unless foreign_keys(table).find_index {|x| x.column == key.to_s}.nil? | ||
| end |
There was a problem hiding this comment.
This utility method was borrowed from past migrations
7 tasks
uponthesun
approved these changes
Jul 27, 2020
Specifically, adding the foreign key constraint on sections.course_id times out when run on an adhoc using a production db clone. This reverts commit f3e2539.
…de-dot-org into create-unit-groups-table
7 tasks
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
One of many steps to complete PLAT-234. please see courses table rename proposal for context.
Description
create
unit_groupsas a complete copy (schema and contents) of thecoursestable, and remove any foreign key constraints against thecoursestable. This encompasses all migrations needed to fully switch to using theunit_groupstable in the next PR.Testing story
see design proposal
Reviewer Checklist: