Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit group unit model #36063

Merged
merged 5 commits into from Jul 30, 2020
Merged

Unit group unit model #36063

merged 5 commits into from Jul 30, 2020

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Jul 29, 2020

These 3 PRs rename CourseScript to UnitGroupUnit everywhere I can find in ruby code, finishing PLAT-235. These PRs to not rename the database table, and they do not rename things like default_script which actually refer to a script object.

Testing story

I am relying on existing test coverage to validate these changes.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@davidsbailey davidsbailey merged commit 37af005 into staging Jul 30, 2020
@davidsbailey davidsbailey deleted the unit-group-unit-model branch July 30, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants