Skip unchanged files in course content sync #36068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bin/i18n/sync-out.rb
Outdated
| sanitize_data_and_write(type_data, "dashboard/config/locales/#{type}.#{locale}.#{extension}") | ||
| type_file = "dashboard/config/locales/#{type}.#{locale}.#{extension}" | ||
|
|
||
| existing_data = YAML.load_file(type_file).dig(locale, "data", type) || {} |
There was a problem hiding this comment.
Aren't these json files now?
There was a problem hiding this comment.
d'oh! That's what I get for testing this before the other changes out there got merged
bethanyaconnor
approved these changes
Jul 31, 2020
bethanyaconnor
approved these changes
Aug 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends our earlier improvements to the sync out to also include course_content files.
Note that unlike the earlier improvements, this one comes with a slight change to functionality. Specifically, in order to be able to skip parsing some files without losing the data in them, we now merge the new data from the sync with the existing data. This means that removing a string from crowdin will no longer remove it from our system. I would definitely consider this a downside, but a relatively minor one compared to the significant time savings this change gets us. I am however quite open to discussion on that point!
Reviewer Checklist: