Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename course to unit group in unit test variable names #36101

Merged
merged 12 commits into from
Aug 2, 2020
Merged

Rename course to unit group in unit test variable names #36101

merged 12 commits into from
Aug 2, 2020

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Jul 31, 2020 •
edited by uponthesun

Continues work on https://codedotorg.atlassian.net/browse/PLAT-234 by renaming course to unit group in variable names, mostly in unit tests.

Testing story

I am relying on existing test coverage.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@davidsbailey davidsbailey changed the base branch from staging to courses-controller-renames July 31, 2020 00:33
@davidsbailey davidsbailey changed the title Rename vars to unit group Rename course to unit group in variable names Jul 31, 2020
@davidsbailey davidsbailey changed the title Rename course to unit group in variable names Rename course to unit group in unit test variable names Jul 31, 2020
@davidsbailey davidsbailey changed the base branch from courses-controller-renames to staging July 31, 2020 00:43
@davidsbailey davidsbailey changed the base branch from staging to courses-controller-renames July 31, 2020 00:44
Base automatically changed from courses-controller-renames to staging August 2, 2020 22:12
@davidsbailey davidsbailey merged commit 2dbabf6 into staging Aug 2, 2020
@davidsbailey davidsbailey deleted the rename-vars-to-unit-group branch August 2, 2020 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@uponthesun uponthesun uponthesun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidsbailey @uponthesun