Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip broken UI test #36148

Merged
merged 1 commit into from Aug 4, 2020
Merged

Skip broken UI test #36148

merged 1 commit into from Aug 4, 2020

Conversation

clareconstantine
Copy link

The fix proposed in #36145 was unsuccessful, so we are skipping this test for now. The test is broken, but the user experience it is testing is not.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

maddiedierker
maddiedierker approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@maddiedierker maddiedierker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@clareconstantine clareconstantine merged commit 0c5fd79 into staging Aug 4, 2020
@clareconstantine clareconstantine deleted the applab-ui-test branch August 4, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maddiedierker maddiedierker maddiedierker approved these changes

@jmkulwik jmkulwik Awaiting requested review from jmkulwik

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clareconstantine @maddiedierker