Deprecate legacy virtual workshop subjects #36283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bencodeorg
changed the title
molly-moen
approved these changes
Aug 20, 2020
clareconstantine
approved these changes
Aug 20, 2020
There's currently no UI way to do this, so I'm comfortable enough that our engineering team won't create any such workshops 🤞 . |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR deprecates code specific to old workshop subjects like "Virtual Workshop 1". The main change is that it removes the suppression of all email for subjects with "Virtual" in the title.
I've left the virtual subjects in place for use by surveys -- I think if I removed these, you wouldn't be able to view survey results for workshops. We might want to remove this eventually?