I18n sync Down & Out 08/17 #36309
Merged
I18n sync Down & Out 08/17 #36309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
approved these changes
Aug 17, 2020
apps/i18n/common/ja_jp.json
Outdated
| "forTeachersOnly": "先生のみ", | ||
| "fromWhen": "({when} から}):\n", |
There was a problem hiding this comment.
@castro-jorge looks like TBH added some syntax (extra }): https://crowdin.com/translate/codeorg/43/enus-ja#136809
| "emptyFunctionBlocksErrorMsg": "関数ブロックは、中に他のブロックがないと動きません。", | ||
| "emptyFunctionalBlock": "入力値が空のブロックがあります。", | ||
| "emptySection": "あなたのセクションには生徒がいません！ [生徒の管理] ({url}) タブに移動して追加してください。\n", |
There was a problem hiding this comment.
Also @castro-jorge with these translations, it looks like there is a lot of broken markdown links
There was a problem hiding this comment.
Thanks for the heads up, will discuss this with TBH in our meeting tomorrow!
…rg/code-dot-org into i18n-sync-down-out-08-17-2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I18n Sync Down & Out
This PR contains all changes to translations made since the last sync (usually a week).
To Review:
Look through the changes in each of the commits and verify that all changes are expected. Note that it is not necessary to review every single "dashboard i18n update" commit. These commits are batched by language to make it easier to review just a couple commits in this category.
Things to Note:
We expect translation changes to come in on a regular basis; new strings will be translated, existing translations will be updated, and source string removals will result in translations for those strings also being removed.
We expect translations to arrive in large batches, so don't worry if you see a large group of changes in a specific language.
We do not usually expect to see a large number of formatting changes, or batches of changes that apply to strings in every single language. If you see this, it usually means either that a code change went in or that something broke.
Known Issues:
If the CI unit tests fail at the
grunt messages:allstep, they will typically fail with a message like:This usually means that a translator has translated one of the MessageFormat variables. In this case, you should find and fix the offending translation in crowdin, and then manually update the associated strings in
i18n/localesandapps/i18n.See ab3e5d1 and 0fca376 for an example.
To Deploy:
Once one or two people have reviewed and approved this change and the tests are passing, ship it!
It's not necessary to wait for everyone on the team to review.