Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Cuantrix to iframe allow list #36325

Merged
merged 1 commit into from
Aug 18, 2020
Merged

Conversation

sureshc
Copy link
Contributor

@sureshc sureshc commented Aug 18, 2020

Add Cuantrix to list of domains that can embed Code.org within an iframe.
https://codedotorg.atlassian.net/browse/INF-363

The allowed_iframe_ancestors attribute is not configured in Chef and there isn't an allowed_iframe_ancestors key in DCDO for any environment.

Testing story

This has been tested on the adhoc-cuantrix adhoc with the Cuantrix test site (cuantrix.gilasw.com).

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@sureshc sureshc requested review from wjordan and Hamms August 18, 2020 17:35
@sureshc sureshc merged commit 4b82c67 into staging Aug 18, 2020
@sureshc sureshc deleted the add-cuantrix-to-iframe-allow-list branch August 18, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants