Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding a button for removing the parent email on a student's account #36347

Merged
merged 4 commits into from
Aug 21, 2020

Conversation

daynew
Copy link
Member

@daynew daynew commented Aug 19, 2020

As a student, I want to be able to remove the parent email associated with my account.

  • Adds "Remove" button/link for setting the parent_email to nil.
  • Adds aria-label's and roles's for the "Update" and "Remove" links so they are easier to use with A11y tools.

Links

Screenshots

Removing a parent email address from a student's account.
remove_parent_email

Testing story

  • Manually tested on localhost

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@daynew daynew requested a review from a team as a code owner August 19, 2020 06:44
@bethanyaconnor
Copy link
Contributor

It's hard to tell from the gif but does removing the parent email redirect to the homepage? If so, I feel like it should stay on the account page

@dju90
Copy link
Contributor

dju90 commented Aug 19, 2020

Unfortunately, that may also be the case with updating other account settings fields too - like updating the "School" field redirects to the teacher dashboard. Ideally, we would keep the user on the account settings page.

@daynew daynew force-pushed the fnd-1249-remove-linked-parent-email branch from 20096d7 to 4aa835d Compare August 19, 2020 17:11
@daynew
Copy link
Member Author

daynew commented Aug 21, 2020

It's hard to tell from the gif but does removing the parent email redirect to the homepage? If so, I feel like it should stay on the account page

Unfortunately, that may also be the case with updating other account settings fields too - like updating the "School" field redirects to the teacher dashboard. Ideally, we would keep the user on the account settings page.

I fixed this redirection.

@daynew daynew merged commit ad0c6f3 into staging Aug 21, 2020
@daynew daynew deleted the fnd-1249-remove-linked-parent-email branch August 21, 2020 16:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants