Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Course Overview Page and Editor Page Use Same Teacher Resources Button as Script #36388

Merged
merged 6 commits into from
Aug 21, 2020

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Aug 21, 2020

We used to limit the number of teacher resources for the Course Overview Page to just 3 resources and we would show each resource as its own button. This makes it so we use the same Teacher Resources Dropdown we use on the Script Overview Page. We now have a TeacherResourceDropdown component that is used both on the editor pages for preview and the overview pages for display.

Course Edit Page After Change

Screen Shot 2020-08-20 at 10 33 42 PM

Course Overview Page After Change

Screen Shot 2020-08-20 at 10 33 30 PM

Follow Up Work

  • Allow curriculum writers to put in their own types for teacher resources
  • Instrumentation for the TeacherResourcesDropdown component

Links

Testing story

  • Updated tests for all existing components
  • Created test for new component

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@dmcavoy dmcavoy changed the title Teacher resources button Make Course Overview Page and Editor Page Use Same Teacher Resources Button as Script Aug 21, 2020
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good!

@dmcavoy dmcavoy merged commit 5ad34de into staging Aug 21, 2020
@dmcavoy dmcavoy deleted the teacher-resources-button branch August 21, 2020 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants