AYW: Update content for post survey #36408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
molly-moen
reviewed
Aug 22, 2020
| "text": "(virtual meeting) Discussing how to counsel students who are disengaging or becoming more passive in class." | ||
| } | ||
| ] | ||
| "html": "<h2>How useful was Module 1?</h2>\n\n<p><span style=\"font-family: arial, helvetica, sans-serif;\">For each activity in this module, we ask that you <strong>rate how useful that activity was to you <em>personally</em></strong> in terms of your own <strong>learning, development, teaching practice</strong>, etc. </span></p>" |
There was a problem hiding this comment.
should the "module_1" matrix be removed?
There was a problem hiding this comment.
Do you mean did I intentionally remove that set of questions? I think the answer is yes, let me confirm with Laura though. She also removed the same set of questions for module 2, I believe.
There was a problem hiding this comment.
ah ok I was slightly confused because it looked like you kept the prompt but removed the question, but it looks like prompt actually goes with the next question as well
There was a problem hiding this comment.
Yep, I think that's right.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated content for AYW post surveys. Took a while to figure out how to reproduce the diffs generated in Laura's new version of the survey in the library questions that generated the survey (even though she told me what they were, and, as you can see in this PR, they're not huge).
Testing story
I made appropriate changes to library question, then re-seeded library questions, then rendered the JSON of the form via /foorm/editor. I used an online JSON diff tool to compare the original JSON file that Laura had provided me with the one generated when using the library questions as updated in this PR and saw no diffs.
Reviewer Checklist: