Course offering seeding fix #36411
Merged
Course offering seeding fix #36411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes this staging seeding failure: https://codedotorg.slack.com/archives/C03CK8E51/p1598249784076000
Which occurred because CourseVerisons exist in the DB that don't have associated CourseOfferings, and this case wasn't handled in the
destroy_and_destroy_parent_if_emptymethod before. This state shouldn't normally exist, but it did because I added logic to seed CourseVersions before adding the CourseOffering model and seeding logic.