Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix progress table so it can display multiple pages of students #36428

Merged
merged 1 commit into from Aug 25, 2020
Merged

Fix progress table so it can display multiple pages of students #36428

merged 1 commit into from Aug 25, 2020

Conversation

jmkulwik
Copy link
Contributor

@jmkulwik jmkulwik commented Aug 25, 2020 •
edited

After the refactor of section progress, we could only display the first page of students (50 students) on the section progress teacher view. This fixes the bug introduced in that refactor.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@jmkulwik jmkulwik requested review from a team, clareconstantine, mvkski and cforkish and removed request for a team August 25, 2020 17:43
mvkski
mvkski approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@mvkski mvkski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving because you want this out ASAP, but would it be possible to add tests in a followup PR?

@jmkulwik
Copy link
Contributor Author

Approving because you want this out ASAP, but would it be possible to add tests in a followup PR?

Good call. Here's the task so I don't forget: https://codedotorg.atlassian.net/browse/LP-1537

@jmkulwik
Copy link
Contributor Author

Unit tests seemed to fail on a transient drone issue. Rerunning.
UI Tests passed here: https://drone.cdn-code.org/code-dot-org/code-dot-org/16853

@jmkulwik jmkulwik merged commit a533bf4 into staging Aug 25, 2020
@jmkulwik jmkulwik deleted the fix-progress-table branch August 25, 2020 20:00
@jmkulwik jmkulwik mentioned this pull request Oct 5, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvkski mvkski mvkski approved these changes

@clareconstantine clareconstantine Awaiting requested review from clareconstantine

@cforkish cforkish Awaiting requested review from cforkish

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jmkulwik @mvkski