Add new facilitator survey to post-email for CSD/CSP #36429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clareconstantine
approved these changes
Aug 25, 2020
| @@ -154,7 +154,14 @@ def facilitator_pre_workshop(user, workshop) | |||
| def facilitator_post_workshop(user, workshop) | |||
| @user = user | |||
| @workshop = workshop | |||
| @survey_url = CDO.studio_url "/pd/misc_survey/facilitator_post", CDO.default_scheme | |||
| # TODO: After 9/5/2020 move all workshops to the new survey (9/5 is last 2020 Summer Workshop) | |||
There was a problem hiding this comment.
Would you mind making a Jira item for this, if we don't already have one?
There was a problem hiding this comment.
Jira item is here we will want to circle back with MeganH when the time so she knows it's done.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our Facilitator post-workshop auto-email to send the new Foorm survey for any non-summer CSD/CSP workshop (we don't send the email for CSF). The survey will be populated with workshop course, workshop subject, and workshop id. This PR also adds the ability to send any variable to a Foorm misc survey via a url parameter.
Future work
After 9/5/2020 we will want to deprecate the old JotForm version of the survey, but we have one more summer workshop before then that we want to have survey data in the same bucket as the other workshops this summer.
Links
Testing story
Validated via the mailer previews that an academic year workshop will show the new survey with the correct variables and a summer workshop will show the old survey.
Reviewer Checklist: