Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding margin above standalone video levels #36455

Merged
merged 1 commit into from
Aug 26, 2020

Conversation

daynew
Copy link
Member

@daynew daynew commented Aug 26, 2020

Adding back a small space between the Code.org header and videos on standalone video levels. This was accidentally removed in a previous PR which made banner and header changes.

Testing story

  • localhost

Screenshots

Before

Note the lack of space between the teal code.org header and the youtube video.
image

After

image

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@daynew daynew requested a review from breville August 26, 2020 04:58
@daynew daynew merged commit 42d0cb8 into staging Aug 26, 2020
@daynew daynew deleted the fix_video_level_header_space branch August 26, 2020 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants