Banner and announcement on the teacher homepage use new strings #36478
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
clareconstantine
requested review from
breville,
a team,
cforkish,
jmkulwik and
mvkski
and removed request for
a team,
cforkish and
jmkulwik
breville
reviewed
Sep 11, 2020
| @@ -3,8 +3,7 @@ | |||
| .special_2020_announcement{style: "text-align: center; background-color: #0094ca; color: white; font-size: 18px; padding: 16px; overflow: hidden"} | |||
| .container_responsive | |||
| .col-66 | |||
| .icon.tablet-feature{style: "float: left; font-size: 60px; padding-right: 30px"} | |||
| %i{:class=>"fa fa-home"} | |||
| %img{src: "/images/homepage/virtual_sync.png", style: "float: left; height: 60px; padding-right: 30px"} | |||
There was a problem hiding this comment.
Should we still include .tablet-feature so that this doesn't show on smaller devices?
There was a problem hiding this comment.
ooh good catch! thank you!
There was a problem hiding this comment.
Sure thing. It's definitely worth double-checking that the page looks good at a variety of widths too, especially for the homepage.
cforkish
approved these changes
Sep 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the new banner image and icon, and start using the new strings.
Signed out homepage:
Signed in teacher homepage:
Links
Testing story
Reviewer Checklist: