Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix NoMethodError #36479

Merged
merged 1 commit into from
Aug 31, 2020
Merged

Fix NoMethodError #36479

merged 1 commit into from
Aug 31, 2020

Conversation

clareconstantine
Copy link

We were getting a NoMethodError when text was nil, so now we handle that case.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@clareconstantine clareconstantine requested review from a team, jmkulwik and mvkski and removed request for a team August 27, 2020 01:50
cforkish
cforkish approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@cforkish cforkish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@clareconstantine clareconstantine merged commit bffdd2d into staging Aug 31, 2020
@clareconstantine clareconstantine deleted the regex-scan-error branch August 31, 2020 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cforkish cforkish cforkish approved these changes

@jmkulwik jmkulwik Awaiting requested review from jmkulwik

@mvkski mvkski Awaiting requested review from mvkski

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@clareconstantine @cforkish