Cap the time_spent recorded per milestone to one hour #36505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have had some cases where a student spends an extreme amount of time on a level between recording milestones. In some cases, a student will even record more time on a level than was physically possible (see "Example" below). In order to prevent such outliers, we are capping the time_spent per milestone to 1 hour.
Example
(Slack Conversation)[https://codedotorg.slack.com/archives/CA3KCSGTD/p1597952388014200]
On Aug 20th, 2020, time_spent recording had been enabled for ~24 hours. During that time, however, we had one student record approximately 19 days worth of time_spent on a single level. This was not possible and was likely due to an issue with the user's system clock.
Additionally, there is some worry that students who leave their browser open overnight or for multiple days will record extremely long time_spent without actually interacting with the site.
These two types of scenarios can erroneously cause large amounts of time_spent recorded for users.
Links
Testing story
Reviewer Checklist: