Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap the time_spent recorded per milestone to one hour #36505

Merged
merged 1 commit into from
Aug 28, 2020
Merged

Conversation

jmkulwik
Copy link
Contributor

We have had some cases where a student spends an extreme amount of time on a level between recording milestones. In some cases, a student will even record more time on a level than was physically possible (see "Example" below). In order to prevent such outliers, we are capping the time_spent per milestone to 1 hour.

Example

(Slack Conversation)[https://codedotorg.slack.com/archives/CA3KCSGTD/p1597952388014200]

On Aug 20th, 2020, time_spent recording had been enabled for ~24 hours. During that time, however, we had one student record approximately 19 days worth of time_spent on a single level. This was not possible and was likely due to an issue with the user's system clock.

Additionally, there is some worry that students who leave their browser open overnight or for multiple days will record extremely long time_spent without actually interacting with the site.

These two types of scenarios can erroneously cause large amounts of time_spent recorded for users.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@jmkulwik jmkulwik requested review from a team, clareconstantine, cforkish and mvkski and removed request for a team August 28, 2020 19:07
Copy link

@clareconstantine clareconstantine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good call on the test!

@jmkulwik jmkulwik merged commit 0553b32 into staging Aug 28, 2020
@jmkulwik jmkulwik deleted the cap-time-spent branch August 28, 2020 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants