Move CSF Deep Dive Surveys to Foorm #36524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Flip CSF Deep Dive urls to use Foorm instead of JotForm. Work to set up the surveys was mostly done in this PR for the pre-survey and this PR for the post-survey. This PR updates the links so that the link that used to direct to JotForm now directs to Foorm. All workshops on or after 9/1 will also show the Foorm results page. There are no Deep Dive workshops between 8/27-9/12, so there is no risk of a workshop getting caught using both JotForm and Foorm.
This was the last survey served by
workshop_daily_survey_controllerto use JotForm, so I removed the JotForm specific code from that file.Links
Testing story
Updated the
workshop_daily_survey_controllerunit tests to reflect the new Foorm version of the survey. I was also able to remove a lot of old tests that validated JotForm-specific code in that controller. I also manually tested the pre and post surveys get linked properly from the dashboard and the results page shows the correct results.Reviewer Checklist: