Cleanup use of button constants #36531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cforkish
requested review from
Hamms,
a team,
clareconstantine and
jmkulwik
and removed request for
a team
jmkulwik
approved these changes
Aug 31, 2020
Hamms
approved these changes
Aug 31, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a small PR to resolve an issue I encountered in LP-1522. I'm putting it in its own PR to create a record of the issue.
I needed to reuse the default height of our
Buttoncomponent in a new button, but when I exported the button heights, that broke theSyncOmniAuthSectionControlcomponent. Long story short, @Hamms helped me figure out that if we are setting class vars on the button (e.g.Button.ButtonColor = ButtonColor;) and we add a non-default export, the class vars are no longer able to be imported individually (e.g.import Button, {ButtonColor, ButtonSize}) unless they are also exported.Most of are coded references these constants through the class vars, so for consistency we decided to update the two files that were using individual imports. I was then able to add my new
ButtonHeightclass var without breaking things.