Move detect board up in promise structure #36593
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Detects the type of board plugged into the serial port. Defaults to BOARD_TYPE.OTHER. | ||
| */ | ||
| export function detectBoardTypeFromPort(port) { |
There was a problem hiding this comment.
can we add unit tests for this function? it's pretty simple now, but my assumption is that we'll be refactoring this method to add logic for detecting micro:bit, and it'll be useful to have test coverage once we add more logic here
added 2 commits
September 11, 2020 09:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussion of issue on Slack: https://codedotorg.slack.com/archives/C0T0EGE8L/p1597679764001300
Summary - A while ago, we fixed an issue - the fourth step on the maker setup-page would display a link to the Adafruit to flash firmware, but the directions at the link were for CPC and would not work for CPE. However, we received a report that there was a similar issue when the third step fails.
This PR adds both links for the third step. Previously, the board type was detected after the third step, so this PR also detects the board type before the third step. To do this, I pulled the detectBoardType method out of SetupChecker so that it had fewer dependencies (relies just on port).
Reviewer Checklist: