Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove lockable script edit #36643

Merged
merged 28 commits into from Sep 16, 2020
Merged

Remove lockable script edit #36643

merged 28 commits into from Sep 16, 2020

Conversation

dmcavoy
Copy link
Contributor

@dmcavoy dmcavoy commented Sep 8, 2020

The lockable setting on lessons will be moving to the lesson edit page so this removes it from the script edit gui.

Screen Shot 2020-09-08 at 3 14 35 PM

Testing story

Updated tests accordingly.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@dmcavoy dmcavoy changed the base branch from staging to add-level-dialog September 14, 2020 19:07
@dmcavoy dmcavoy changed the base branch from add-level-dialog to staging September 16, 2020 01:17
@dmcavoy dmcavoy merged commit ff2553a into staging Sep 16, 2020
@dmcavoy dmcavoy deleted the remove-lockable-script-edit branch September 16, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants