Upgrade to latest version of Drone server #36712
Conversation
This reverts commit 56a8af1.
This reverts commit f6a1c48.
…t Drone Runner 1.5 Update DRONE_RPC_HOST to pass just the hostname. Update build script to eliminate check for fork because that's supported natively with a Repository specific setting in Drone server 1.9.
…ude` rule is used. Trigger builds for any event where the target branch is staging or staging-next.
sureshc
force-pushed
the
upgrade-drone-server
branch
from
298f8d4
to
d4c4a75
Compare
sureshc
requested review from
wjordan and
uponthesun
and removed request for
wjordan
| @@ -15,24 +16,6 @@ steps: | |||
| - git remote set-branches --add origin $DRONE_TARGET_BRANCH | |||
| - git fetch --depth 100 origin $DRONE_TARGET_BRANCH | |||
|
|
|||
| - name: verify-pr | |||
There was a problem hiding this comment.
Removing this logic because I saw this Step intermittently failing and because there's now a native feature in Drone server that provides this functionality. Here's a Pull Request from a fork that Drone correctly did not execute in a Build.
https://drone.cdn-code.org/code-dot-org/code-dot-org/settings
There was a problem hiding this comment.
That's great, I never liked having so much logic in the .drone.yml file.
| @@ -261,7 +261,8 @@ Resources: | |||
| KeyName: !Sub "winter-dev-${AWS::Region}" | |||
| SecurityGroupIds: | |||
| - !Ref DroneWorkerEcsSecurityGroup | |||
| ImageId: ami-0c4b05c0409735671 | |||
| # ECS Optimized AMI - https://docs.aws.amazon.com/AmazonECS/latest/developerguide/ecs-optimized_AMI.html | |||
| ImageId: ami-04bb74f3ffa3aa3e2 | |||
There was a problem hiding this comment.
Drone Server 1.9 issues Docker API calls that require a newer version of Docker, which is available by upgrading to the latest version of ECS-optimized (docker pre-installed) Amazon Linux.
| @@ -15,24 +16,6 @@ steps: | |||
| - git remote set-branches --add origin $DRONE_TARGET_BRANCH | |||
| - git fetch --depth 100 origin $DRONE_TARGET_BRANCH | |||
|
|
|||
| - name: verify-pr | |||
There was a problem hiding this comment.
That's great, I never liked having so much logic in the .drone.yml file.
Prerequisite for using Drone Autoscaler.
We were previously running Drone Server 1.0.0-rc.5 and Drone Worker/Agent 1.0.0-rc.5.
Upgrade to latest Drone Server (1.9.0) and latest Drone Runner (1.5.0), in preparation for adopting Drone Autoscaler and also to take advantage of new functionality in Drone.
Testing story
Drone build 17356 contains changes to dashboard, pegasus, lib, and shared folders to trigger unit tests for those sub-projects. It ran successfully, but I haven't analyzed the unit test logs closely to ensure that all of the expected unit tests were triggered correctly.
Drone build 17355 contains a change to the apps directory and failed during execution of unit tests. I'm still analyzing why they failed. I'm re-running a build on that commit.
Reviewer Checklist: