Update trademark string in hourofcode.com footer #36730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to include Hora del Código
daynew
approved these changes
Sep 12, 2020
| @@ -643,7 +643,7 @@ | |||
| highlights_constant_athletes_short_heading: Push yourself | |||
|
|
|||
| footer_copyright_message: 'Copyright %{current_year} Code.org. All rights reserved.' | |||
| footer_trademark_message: 'Hour of Code™ is a trademark of Code.org.' | |||
| footer_trademark_message: 'Hour of Code™ and Hora del Código® are trademarks of Code.org.' | |||
There was a problem hiding this comment.
Are we worried about old translations not including Hora del Código®?
There was a problem hiding this comment.
No, it's not urgent. Jorge and I will follow up in Crowdin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to include Hora del Código, since we recently obtained the trademark for it in Mexico
Links
Testing story
Tested on localhost
Reviewer Checklist: