Create and Set Up Add level dialog for Activities Editor GUI #36732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Sep 14, 2020
|
|
||
| //TODO: Set up creating a new level. Make sure dropdown has all level types | ||
|
|
||
| export default class AddLevelFilters extends Component { |
There was a problem hiding this comment.
Huh, how does the code even work as-is? Is it because of export default?
There was a problem hiding this comment.
exactly. importing the default implicitly sets the name of the import.
Comment on lines
+99
to
+100
| {this.state.methodOfAddingLevel === 'Create New Level' && ( | ||
| <CreateNewLevelInputs /> |
There was a problem hiding this comment.
can you please include a screenshot of what this looks like?
uponthesun
approved these changes
Sep 14, 2020
|
|
||
| //TODO: Set up creating a new level. Make sure dropdown has all level types | ||
|
|
||
| export default class AddLevelFilters extends Component { |
There was a problem hiding this comment.
Huh, how does the code even work as-is? Is it because of export default?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This splits out some of the work that was in #36627. You can watch the gif below to see what happens when you click add level. The dialog that shows when you click add level is all the components in this PR.
Links
Testing story
Added simple unit tests for each component.
Reviewer Checklist: