I18n maker setup list #36787
Merged
I18n maker setup list #36787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 11 commits
September 10, 2020 14:54
Comment on lines
+289
to
+291
| {applabI18n.makerSetupPlugInBoardCheck()} | ||
| <a href="#" onClick={this.redetect.bind(this)}> | ||
| re-detect | ||
| {applabI18n.redetect()} |
There was a problem hiding this comment.
[incorporate these strings into 1 for i18n]
There was a problem hiding this comment.
Hi there! Can you let me know which string parts you are looking at here? Thanks!
There was a problem hiding this comment.
of course -- i was thinking we could condense applabI18n.makerSetupPlugInBoardCheck and applabI18n.redetect using the <SafeMarkdown/> component, but now i realize that won't work because the onClick handler here won't play nicely with markdown, so you can ignore this one 😄
maddiedierker
approved these changes
Sep 22, 2020
|
@code-dot-org/i18n - I would love a quick check on this to make sure it's following best practice - thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All the maker i18n things! This builds on PR:
#36689 to make the maker set-up process i18n-ed before I add the micro:bit.
This page is the 4 step process that folks go through to make sure their CP board is working correctly. There should be no functional changes and very minor styling changes. One change I made was to break up the sentence: "We couldn't detect a Circuit Playground board. Make sure your board is plugged in, and click re-detect." to be {We couldn't detect a Circuit Playground board. Make sure your board is plugged in, and click: } {re-detect}. This is because the re-detect has an onClick attached to it and breaking this up allowed each of those strings to be i18n'ed and still have re-detect have an onClick. My hope is that because "re-detect" also appears as a button at the top of the page, this will make sense when translated. If not, let me know and I'll head back to the drawing board with it. I included before and after images of this change.
Before:
After:
Reviewer Checklist: