Update i18n instruction on security risks #36869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
reviewed
Sep 23, 2020
Hamms
approved these changes
Sep 25, 2020
| @@ -10,7 +10,7 @@ | |||
| .external-link-disclaimer | |||
| %h2= t('external_links.disclaimer') | |||
| %strong= t('external_links.leaving_domain') | |||
| %p!= t('external_links.disclaimer_text', support_url: 'https://support.code.org') | |||
| %p!= t('external_links.disclaimer_text', support_url: 'https://support.code.org', markdown: true) | |||
There was a problem hiding this comment.
nit: this should probably be either
Suggested change
| %p!= t('external_links.disclaimer_text', support_url: 'https://support.code.org', markdown: true) | |
| %p!= t('external_links.disclaimer_text', support_url: 'https://support.code.org', markdown: :inline) |
or
Suggested change
| %p!= t('external_links.disclaimer_text', support_url: 'https://support.code.org', markdown: true) | |
| != t('external_links.disclaimer_text', support_url: 'https://support.code.org', markdown: true) |
the difference between the two being that the regular case means the markdown will handle its own block-level elements like paragraphs and lists and whatnot, while the inline case will produce content suitable for embedding inside an existing block-level element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task FND-1259:
markdown: true.Links
Slack discussions
From Ben 8/12/2020
From Elijah 7/16/2020