Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make UserSchoolInfo tests slightly more resilient #36927

Merged
merged 1 commit into from
Sep 28, 2020
Merged

Make UserSchoolInfo tests slightly more resilient #36927

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
41 changes: 26 additions & 15 deletions dashboard/test/controllers/api/v1/user_school_infos_controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -360,15 +360,16 @@ def assert_first_tenure(user)

test 'confirmation, partial previous, blank, manual' do
complete_school_info = SchoolInfo.create({country: 'United States', school_type: 'public', school_name: 'Philly High Harmony', full_address: 'Seattle, Washington', validation_type: SchoolInfo::VALIDATION_COMPLETE})
@teacher.update(school_info: complete_school_info)
assert @teacher.update(school_info: complete_school_info)

Timecop.travel 1.year
@teacher.reload

partial_school_info = SchoolInfo.create({country: 'United States', school_type: 'public', school_name: nil, full_address: 'Seattle, Washington', validation_type: SchoolInfo::VALIDATION_COMPLETE})
result = @teacher.update(school_info: partial_school_info)
assert_equal false, result
refute @teacher.update(school_info: partial_school_info)

Timecop.travel 7.days
@teacher.reload

sign_in @teacher
submit_blank_school_info
Expand All @@ -380,14 +381,16 @@ def assert_first_tenure(user)

test 'confirmation, partial previous, unchanged, manual' do
complete_school_info = SchoolInfo.create({country: 'US', school_type: 'public', school_name: 'Philly High Harmony', full_address: 'Seattle, Washington', validation_type: SchoolInfo::VALIDATION_COMPLETE})
@teacher.update(school_info: complete_school_info)
assert @teacher.update(school_info: complete_school_info)

Timecop.travel 1.year
@teacher.reload

partial_school_info = SchoolInfo.create({country: 'US', school_type: 'public', school_name: nil, full_address: 'Seattle, Washington', validation_type: SchoolInfo::VALIDATION_COMPLETE})
@teacher.update(school_info: partial_school_info)
refute @teacher.update(school_info: partial_school_info)

Timecop.travel 7.days
@teacher.reload

sign_in @teacher
submit_unchanged_school_info partial_school_info
Expand All @@ -401,14 +404,16 @@ def assert_first_tenure(user)

test 'confirmation, partial previous, partial, manual' do
complete_school_info = SchoolInfo.create({country: 'United States', school_type: 'public', school_name: 'Philly High Harmony', full_address: 'Seattle, Washington', validation_type: SchoolInfo::VALIDATION_COMPLETE})
@teacher.update(school_info: complete_school_info)
assert @teacher.update(school_info: complete_school_info)

Timecop.travel 1.year
@teacher.reload

partial_school_info = SchoolInfo.create({country: 'United States', school_type: 'public', school_name: nil, full_address: 'Seattle, Washington', validation_type: SchoolInfo::VALIDATION_COMPLETE})
@teacher.update(school_info: partial_school_info)
refute @teacher.update(school_info: partial_school_info)

Timecop.travel 7.days
@teacher.reload

sign_in @teacher
submit_partial_school_info
Expand All @@ -425,14 +430,16 @@ def assert_first_tenure(user)
new_school = create :school

complete_school_info = SchoolInfo.create({country: 'United States', school_type: 'public', school_name: 'Philly High Harmony', full_address: 'Seattle, Washington', validation_type: SchoolInfo::VALIDATION_COMPLETE})
@teacher.update(school_info: complete_school_info)
assert @teacher.update(school_info: complete_school_info)

Timecop.travel 1.year
@teacher.reload

partial_school_info = SchoolInfo.create({country: 'United States', school_type: 'public', school_name: nil, full_address: 'Seattle, Washington', validation_type: SchoolInfo::VALIDATION_COMPLETE})
@teacher.update(school_info: partial_school_info)
refute @teacher.update(school_info: partial_school_info)

Timecop.travel 7.days
@teacher.reload

sign_in @teacher
submit_complete_school_info_from_dropdown(new_school)
Expand All @@ -447,14 +454,16 @@ def assert_first_tenure(user)

test 'confirmation, partial previous, complete, manual' do
complete_school_info = SchoolInfo.create({country: 'United States', school_type: 'public', school_name: 'Philly High Harmony', full_address: 'Seattle, Washington', validation_type: SchoolInfo::VALIDATION_COMPLETE})
@teacher.update(school_info: complete_school_info)
assert @teacher.update(school_info: complete_school_info)

Timecop.travel 1.year
@teacher.reload

partial_school_info = SchoolInfo.create({country: 'United States', school_type: 'public', school_name: nil, full_address: 'Seattle, Washington', validation_type: SchoolInfo::VALIDATION_COMPLETE})
@teacher.update(school_info: partial_school_info)
refute @teacher.update(school_info: partial_school_info)

Timecop.travel 7.days
@teacher.reload

sign_in @teacher
submit_complete_school_info_manual
Expand All @@ -473,18 +482,20 @@ def assert_first_tenure(user)
new_school = create :school

complete_school_info = SchoolInfo.create({country: 'United States', school_type: 'public', school_name: 'Philly High Harmony', full_address: 'Seattle, Washington', validation_type: SchoolInfo::VALIDATION_COMPLETE})
@teacher.update(school_info: complete_school_info)
assert @teacher.update(school_info: complete_school_info)

second_teacher_complete_school_info = SchoolInfo.create({country: 'United States', school_type: 'public', school_name: 'School of Rock', full_address: 'Harrisburg, PA', validation_type: SchoolInfo::VALIDATION_COMPLETE})
@second_teacher.update(school_info: second_teacher_complete_school_info)
assert @second_teacher.update(school_info: second_teacher_complete_school_info)

Timecop.travel 1.year
@teacher.reload

partial_school_info = SchoolInfo.create({country: 'United States', school_type: 'public', school_name: nil, full_address: 'Seattle, Washington', validation_type: SchoolInfo::VALIDATION_COMPLETE})
@teacher.update(school_info: partial_school_info)
@second_teacher.update(school_info: partial_school_info)
refute @teacher.update(school_info: partial_school_info)
refute @second_teacher.update(school_info: partial_school_info)

Timecop.travel 7.days
@teacher.reload

sign_in @teacher
submit_complete_school_info_from_dropdown(new_school)
Expand Down