Allow editing of lesson group fields in script editor gui #36968
Conversation
There was a problem hiding this comment.
The UX seems like it might be a bit confusing regarding "user facing". this implementation mirrors what's in the database, but I think we could probably offer a simpler mental model to the editor.
In the first screenshot, when there is only one non-user-facing lesson group, what do you think about taking away the "user facing" button on the lesson group, and replacing the "add lesson group" button on the Unit card with a button named "enable lesson groups"?
In this state, you could also omit this header row:
usual caveat: I am not a UX designer. :-) any thoughts? any input, @tess323 ?
| lessonGroup: { | ||
| key: 'lg-key', | ||
| display_name: 'Display Name', | ||
| position: 1, | ||
| user_facing: true, | ||
| description: 'Lesson group description', | ||
| big_questions: '', |
There was a problem hiding this comment.
now seems like a good time to add a test showing that these two fields appear in the shallow render.
I talked to Tess and she agreed with your thoughts on the design. We also talked about preventing you from ever having 0 lesson groups. Instead if you are starting a new script or delete all the existing lesson groups we will have a non-user facing lesson group already provided for you. I'm going to work on these changes and I will update the PR. |
|
@tess323 @davidsbailey Updated!
|
|
nice improvements! top-level comment: I would suggest hiding the up / down / delete controls in the case where lesson groups are not enabled: |
| // Remove lesson group when there is only one lesson group left | ||
| // a non-user facing lesson group should be added |
There was a problem hiding this comment.
If I am understanding correctly then I'm a bit worried about this user flow - if i enable lesson groups, then realize I've made a mistake, it seems much more likely that I'll want to convert the one remaining lesson group back to non-user-facing, as opposed to deleting all my lessons. I don't have an exact solution in mind, but accidentally clicking "enable" seems like a bit of a land mine for curriculum writers.
There was a problem hiding this comment.
I'll look at how hard it is to have a disable lesson groups button if there is only one lesson group
There was a problem hiding this comment.
ok, this would be fine to resolve in a future PR / discussion if that's easier.
| // Remove lesson group when there is only one lesson group left | ||
| // a non-user facing lesson group should be added |
There was a problem hiding this comment.
ok, this would be fine to resolve in a future PR / discussion if that's easier.
|
@davidsbailey @tess323 How does this flow look?
|
|
❤️ 🚀 👍 awesome work Dani! This seals off all the problem cases I was worried about. |
Adds the ability to edit the Lesson Group name, description and big questions on the LessonGroupCard in the Script Editor GUI. The input/textareas only show if the Lesson Group is user facing. Otherwise it shows that you need to make the LessonGroup user facing and provides a button to do so.
Not User Facing
User Facing
Links
Testing story
Reviewer Checklist: