Switch Geocoder to use Mapbox API instead of Google Maps API #37009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daynew
force-pushed
the
plc-1300-replace-geocoder-gmaps-with-mapbox
branch
2 times, most recently
from
07e640a
to
05a2b6e
Compare
bethanyaconnor
approved these changes
Oct 6, 2020
lib/cdo/geocoder.rb
Outdated
| @@ -31,7 +31,7 @@ def self.find_potential_street_address(text) | |||
| results = Geocoder.search(first_number_to_end) | |||
| return nil if results.empty? | |||
|
|
|||
| if results.first.types.include?('street_address') | |||
| if results.first.address | |||
There was a problem hiding this comment.
Putting a comment here but I was trying to run this and it was crashing in summarize as a number of those attributes , such as street_address, don't exist for Mapbox. Can you take a look?
|
I'm a bit more worried about this change than I was yesterday. How much have you tested? I'm mostly concerned by the fact that the responses from the two APIs seem to be quite different and a lot of places in our code base use this class |
daynew
force-pushed
the
plc-1300-replace-geocoder-gmaps-with-mapbox
branch
from
05a2b6e
to
b66dc04
Compare
daynew
force-pushed
the
plc-1300-replace-geocoder-gmaps-with-mapbox
branch
from
b66dc04
to
388f732
Compare
|
Added tests and will manually test in staging. I will get a proper review during the week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Soon we will no longer be able to use the Google Maps API. This change switches our
Geocoder.searchmethod calls to use the Mapbox API instead.Links
Testing story
Reviewer Checklist: