Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use our custom fork of sassc-rails #37094

Merged
merged 3 commits into from
Oct 7, 2020
Merged

Use our custom fork of sassc-rails #37094

merged 3 commits into from
Oct 7, 2020

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Oct 6, 2020

While we work on getting our patch accepted upstream.

Part of the ongoing Rails 6 upgrade work.

Testing story

Relying on existing unit (and eyes) tests.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms added the Rails Upgrade All work related to upgrading the version of Ruby on Rails we use. label Oct 6, 2020
@Hamms Hamms mentioned this pull request Oct 6, 2020
Closed
8 tasks
@Hamms Hamms marked this pull request as ready for review October 6, 2020 22:33
@Hamms Hamms requested a review from wjordan October 7, 2020 18:18
@Hamms Hamms merged commit a0fec5c into staging Oct 7, 2020
@Hamms Hamms deleted the use-custom-fork-of-sassc-rails branch October 7, 2020 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wjordan wjordan wjordan approved these changes

Assignees
No one assigned
Labels
Rails Upgrade All work related to upgrading the version of Ruby on Rails we use.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @wjordan