Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JotForm: Stop syncing unused form types #37102

Merged
merged 2 commits into from
Oct 7, 2020
Merged

Conversation

molly-moen
Copy link
Contributor

The only remaining JotForm backed forms we support are misc surveys. Stop trying to sync the old form types (WorkshopDailySurvey, WorkshopFacilitatorDailySurvey, and PostCourseSurvey) via our JotForm cron jobs. Also added comments to the above models to indicate they are legacy and nothing new should be added. For now we are keeping the models so we can see the old data.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@molly-moen molly-moen requested review from a team, cforkish and jamescodeorg and removed request for a team October 6, 2020 22:21
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fantastic!

@molly-moen molly-moen merged commit b955303 into staging Oct 7, 2020
@molly-moen molly-moen deleted the clean-up-jotform branch October 7, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants