Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused file administrators.js #37115

Merged
merged 1 commit into from
Oct 7, 2020
Merged

Conversation

hacodeorg
Copy link
Contributor

Per this Slack discussion, pegasus/sites.v3/code.org/public/administrators.md.erb was deleted and replaced by administrators.erb, which no longer use apps/src/sites/code.org/pages/public/administrators.js.

The administrators.js file is no longer used in any file, causing staging and test builds to fail with this error

Running "lint-entry-points" task
✘ code.org/public/administrators ➜ ./src/sites/code.org/pages/public/administrators.js
  ✘ Entry points should only be used by one template but this one is used by 0!
[117 passed] [30 silenced] [1 failed]
Warning: 1 entry points do not conform to naming conventions.
Run grunt check-entry-points for details.
� Use --force to continue.

The fix is to remove administrators.js completely.

@hacodeorg hacodeorg merged commit 3d4a863 into staging Oct 7, 2020
@hacodeorg hacodeorg deleted the ha/remove-unused-entry-point branch October 7, 2020 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants