Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use activity section position to order ActivitySection script_levels #37143

Merged
merged 2 commits into from
Oct 10, 2020
Merged

Use activity section position to order ActivitySection script_levels #37143

merged 2 commits into from
Oct 10, 2020

Conversation

davidsbailey
Copy link
Member

Follow-on to migration in #37142 .

Testing story

added a new unit test. there's nothing to test in the app yet because we are still using stub data in the UI.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@davidsbailey davidsbailey changed the base branch from staging to activity-section-position-migration October 8, 2020 21:57
@davidsbailey davidsbailey mentioned this pull request Oct 9, 2020
Merged
8 tasks
Base automatically changed from activity-section-position-migration to staging October 9, 2020 21:12
@davidsbailey davidsbailey merged commit 966a283 into staging Oct 10, 2020
@davidsbailey davidsbailey deleted the use-activity-section-position branch October 10, 2020 00:16
@davidsbailey davidsbailey mentioned this pull request Oct 11, 2020
Merged
8 tasks
@daynew daynew mentioned this pull request Oct 11, 2020
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bethanyaconnor bethanyaconnor bethanyaconnor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@davidsbailey @bethanyaconnor