Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Google Maps code in favor of Mapbox #37153

Merged
merged 3 commits into from Oct 9, 2020
Merged

Remove Google Maps code in favor of Mapbox #37153

merged 3 commits into from Oct 9, 2020

Conversation

bethanyaconnor
Copy link
Contributor

@bethanyaconnor bethanyaconnor commented Oct 9, 2020 •
edited

Follow up to #36936. This removes the google maps api calls and only shows the Mapbox map.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

breville
breville reviewed Oct 9, 2020
View reviewed changes
apps/src/sites/code.org/pages/views/workshop_search.js Outdated
.setHTML(description)
.addTo(map);
.setHTML(description);
//popup.addClassName('popup');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove this?

@bethanyaconnor bethanyaconnor changed the title Replace workshop map with mapbox Remove Google Maps code in favor of Mapbox Oct 9, 2020
@bethanyaconnor bethanyaconnor merged commit 85942b9 into staging Oct 9, 2020
@bethanyaconnor bethanyaconnor deleted the replace-workshop-map-with-mapbox branch October 9, 2020 17:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breville breville breville approved these changes

@daynew daynew Awaiting requested review from daynew

Assignees
No one assigned
Labels
mapbox
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bethanyaconnor @breville