Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrating to MapboxLocationSearchField Component #37160

Merged
merged 1 commit into from
Oct 11, 2020

Conversation

daynew
Copy link
Member

@daynew daynew commented Oct 9, 2020

We have a React component called GoogleSchoolLocationSearchField which needs to be replaced by a Mapbox implementation because we will not be have access to the Google Maps APIs in a few days.

  • Adds the Yarn dependency @mapbox/mapbox-gl-geocoder
  • Deletes GoogleSchoolLocationSearchField
  • Creates MapboxLactionsSearchField React component which displays a text input field the user can use to easily find geographic locations.
  • Some light scrubbing of "Google" from variable names.

Links

Testing story

Screenshots

http://localhost-studio.code.org:3000/home?forceSchoolInfoInterstitial=true

image

http://localhost-studio.code.org:3000/home?forceSchoolInfoConfirmationDialog=true

image

http://localhost-studio.code.org:3000/home?forceCensusBanner=true

Screen Shot 2020-10-09 at 12 19 15 AM

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@daynew daynew force-pushed the fnd-1307-replace-google-maps-on-school-info-popup branch 2 times, most recently from 9f640a0 to f928908 Compare October 11, 2020 04:41
@daynew daynew force-pushed the fnd-1307-replace-google-maps-on-school-info-popup branch from f928908 to 61836c0 Compare October 11, 2020 21:07
@daynew
Copy link
Member Author

daynew commented Oct 11, 2020

This needs to go in today, so I will test this in staging. I will follow up with a proper review during the week.

@daynew daynew merged commit 42b7463 into staging Oct 11, 2020
@daynew daynew deleted the fnd-1307-replace-google-maps-on-school-info-popup branch October 11, 2020 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant