Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Spritelab] Add user input blocks for prototyping (behind experiment) #37204

Merged
merged 4 commits into from
Oct 13, 2020
Merged

[Spritelab] Add user input blocks for prototyping (behind experiment) #37204

merged 4 commits into from
Oct 13, 2020

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Oct 12, 2020

New blocks:

image
image

Basic Usage:
Oct-12-2020 14-04-58

Caveats:

  • For prototyping only at this point (hidden behind experiment flag spritelabInput)
  • UI not yet finalized

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@ajpal ajpal requested a review from a team October 12, 2020 21:07
breville
breville reviewed Oct 12, 2020
View reviewed changes
apps/src/p5lab/spritelab/coreLibrary.js
Comment on lines +177 to +178
// Make sure to call the setter callback to set the variable
// before the user callback, which may rely on the variable's new value
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

breville
breville approved these changes Oct 12, 2020
View reviewed changes
Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not terribly familiar but this seems clean and effective. The PR's animated GIF does a good job of telling the end-to-end story!

@ajpal ajpal merged commit 8294106 into staging Oct 13, 2020
@ajpal ajpal deleted the oct9-spritelab-input-experiment branch October 13, 2020 16:09
@ajpal ajpal mentioned this pull request Jan 15, 2021
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@breville breville breville approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ajpal @breville