New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update advocacy banner for 2020 State of CS Report #37208

Merged

clareconstantine merged 1 commit into staging from advocacy-banner

Oct 13, 2020

clareconstantine commented Oct 12, 2020

New banner:

Mobile:

Links

jira

Testing story

Reviewer Checklist:

Tests provide adequate coverage
Privacy and Security impacts have been assessed
Code is well-commented
New features are translatable or updates will not break translations
Relevant documentation has been added or updated
User impact is well-understood and desirable
Pull Request is labeled appropriately
Follow-up work items (including potential tech debt) are tracked and linked


          update advocacy banner

76054d5

clareconstantine requested review from molly-moen, breville and tess323

October 12, 2020 23:57

breville approved these changes

View reviewed changes

Member

breville left a comment

Thanks for screenshotting mobile as well as desktop!

tess323 approved these changes

View reviewed changes

tess323 left a comment

This looks great!

clareconstantine merged commit f6c1101 into staging

clareconstantine deleted the advocacy-banner branch

October 13, 2020 03:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment