Add resource search for autocomplete #37224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bethanyaconnor
changed the title
davidsbailey
approved these changes
Oct 14, 2020
| @@ -0,0 +1,12 @@ | |||
| class ResourcesAutocomplete < AutocompleteHelper | |||
There was a problem hiding this comment.
nice find on AutocompleteHelper!
Comment on lines
+4
to
+6
| # We rely on fulltext indices to be used in this test. | ||
| # In order to get this test to work, we need to have the resources created | ||
| # as fixtures. These are defined in test/fixtures/resource.yml |
There was a problem hiding this comment.
thanks for documenting. this strategy seems fine for now, though I'm a bit worried it will no longer work once we are only searching within a specific course version.
dmcavoy
reviewed
Oct 14, 2020
|
|
||
| rows = Resource.limit(limit) | ||
| query = format_query(query) | ||
| return [] if query.length < MIN_WORD_LENGTH + 2 |
There was a problem hiding this comment.
The query adds a symbol on each side of the word. I'll add a comment.
There was a problem hiding this comment.
Actually, I'm going to move it up a line and not bother with the +2 thing
dmcavoy
reviewed
Oct 14, 2020
| # In order to get this test to work, we need to have the resources created | ||
| # as fixtures. These are defined in test/fixtures/resource.yml | ||
|
|
||
| test "finds resource with matching name" do |
There was a problem hiding this comment.
Maybe add a test for when there is less than 5 characters in the search?
dmcavoy
approved these changes
Oct 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #37118, which added the front end search calls. This actually implements the autocomplete search part, on name and URL.
I had a fair number of issues with the test for this. Adding a fixture that is seeded into the test database solved those. I think the issue was that this feature relies on an index and the tests just weren't creating those fast enough, but that's just a theory.
Links
Testing story
unit test in addition to manual testing
Reviewer Checklist: