validate level key and re-enable script edit gui test #37239
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #37236 . Adds validations and tests ensuring that we can compute
key
for all levels, and re-enables the script gui edit page ui test scenario. I was not able to track down why a bunch of PeerReview objects would have levels without game set properly, so I went a bit overboard with precautions by running validations on create as well as update and also adding a safety check against problematic test fixtures.Testing story
After deleting problematic Level and PeerReview objects for the
test
machine, theLevel.key_list
command now completes there successfully. That combined with the added validations and tests should help ensure thatLevel.key_list
does not break again in the future.Reviewer Checklist: