Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

validate level key and re-enable script edit gui test #37239

Merged
merged 6 commits into from Oct 15, 2020

Conversation

davidsbailey
Copy link
Member

@davidsbailey davidsbailey commented Oct 14, 2020

Follow on to #37236 . Adds validations and tests ensuring that we can compute key for all levels, and re-enables the script gui edit page ui test scenario. I was not able to track down why a bunch of PeerReview objects would have levels without game set properly, so I went a bit overboard with precautions by running validations on create as well as update and also adding a safety check against problematic test fixtures.

Testing story

After deleting problematic Level and PeerReview objects for the test machine, the Level.key_list command now completes there successfully. That combined with the added validations and tests should help ensure that Level.key_list does not break again in the future.

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@davidsbailey davidsbailey changed the title validate level key does not raise validate level key and re-enable script edit gui test Oct 14, 2020
@davidsbailey davidsbailey merged commit 3f84239 into staging Oct 15, 2020
@davidsbailey davidsbailey deleted the validate-level-key branch October 15, 2020 17:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants