[Spritelab] New Blocks #37242
Merged
[Spritelab] New Blocks #37242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove sin/cos blocks, which were added in [Spritelab] sin/cos blocks for prototyping #36885, because turns out those are blockly default blocks so we don't need to re-implement them
withPercentChance
ifVarEquals
This is the first levelbuilder-defined block with a variable dropdown, so I also had to add a case for that (see block_utils change)
isCostumeEqual
withPercentChanceandifVarEqualsare implemented in the interpreter, not natively. I added comments to the interpreted library as well, but basically, they are functions with callbacks, but we want them to act like regular if statements. That is, we want the callback to finish executing before the function returns, which would not be the case if the function is implemented natively and has a callback into the interpreter.See sprite lab block requests