Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding nil/empty string check for to the Geocoder #37281

Merged
merged 1 commit into from Oct 16, 2020
Merged

Adding nil/empty string check for to the Geocoder #37281

merged 1 commit into from Oct 16, 2020

Conversation

daynew
Copy link
Member

@daynew daynew commented Oct 16, 2020

We received a Honeybadger error report that the Geocoder is being given nil or empty strings. This adds a check and tests for that.

Links

Testing story

  • Unit tests added

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@daynew daynew force-pushed the fix-honey-badger-string-scan-error branch from 9643c25 to 626b38f Compare October 16, 2020 00:10
@daynew daynew merged commit 772552f into staging Oct 16, 2020
@daynew daynew deleted the fix-honey-badger-string-scan-error branch October 16, 2020 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamescodeorg jamescodeorg jamescodeorg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@daynew @jamescodeorg