Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass id to volunteer contact form #37318

Merged
merged 1 commit into from
Oct 19, 2020
Merged

Pass id to volunteer contact form #37318

merged 1 commit into from
Oct 19, 2020

Conversation

bethanyaconnor
Copy link
Contributor

@bethanyaconnor bethanyaconnor commented Oct 19, 2020

See Slack thread

The contact form started returning a 400 error on submit, likely as a result of replacing Google Maps with Mapbox. The request wasn't sending the volunteer ID, which was required.

Screenshot 2020-10-19 at 11 50 41 AM

This fix tried to emulate the removed code, which was setting a hidden form field. It isn't a pretty fix, but I tested locally and I can submit the form. Definitely open to suggestions for improvements.

Links

Testing story

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

Copy link
Member

@breville breville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@bethanyaconnor bethanyaconnor merged commit 2c6e648 into staging Oct 19, 2020
@bethanyaconnor bethanyaconnor deleted the volunteer-map-400 branch October 19, 2020 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants