Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resources section to teacher-facing lesson plan #37445

Merged
merged 7 commits into from Oct 27, 2020

Conversation

bethanyaconnor
Copy link
Contributor

@bethanyaconnor bethanyaconnor commented Oct 26, 2020

Adds resources to the lesson front page.

The "audience" field changed a bit from CB, where it was a checkbox indicating whether it was a teacher resource or not.

  • Currently, the audience field isn't required (though maybe we should think about requiring that), so I added a catch-all "All" bucket for now.
  • In addition, there is an option for "Verified Teacher". I added some logic on the backend to only display those resources if the current user is an authorized_teacher.

Authorized teacher:
Screenshot 2020-10-26 at 10 59 53 AM

Signed out user:
Screenshot 2020-10-26 at 11 00 05 AM

Links

Testing story

manual testing and unit tests

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@bethanyaconnor bethanyaconnor marked this pull request as ready for review October 26, 2020 19:45
@bethanyaconnor bethanyaconnor requested a review from a team as a code owner October 26, 2020 19:45
Copy link
Member

@davidsbailey davidsbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, Bethany!

@bethanyaconnor bethanyaconnor merged commit 37812e0 into staging Oct 27, 2020
@bethanyaconnor bethanyaconnor deleted the resources-to-lesson-plan branch October 27, 2020 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants