Revert "Revert "Remove deprecated :text option to render"" #37580
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hamms
added
the
Rails Upgrade
davidsbailey
approved these changes
Oct 30, 2020
| @@ -142,7 +142,7 @@ def pd_progress | |||
| ) | |||
| render( | |||
| layout: 'application', | |||
| text: "PD progress data not found for #{sanitized_script_name}.", | |||
| plain: "PD progress data not found for #{sanitized_script_name}.", | |||
There was a problem hiding this comment.
These two seem worth verifying before merging since they also specify a layout.
There was a problem hiding this comment.
oh wow, nice catch; I literally looked right at these and didn't see a layout 🙃
… also added tests
davidsbailey
approved these changes
Nov 2, 2020
Hamms
deleted the
revert-37571-revert-37509-remove-deprecated-text-render
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #37571, restoring #37509
It turns out I was slightly wrong about my understanding of the deprecation.
render textused to be able to either render just a raw text response OR render text into an html layout, with the use of the layout keyword. This behavior was confusing, sorender textwas broken up intorender plainandrender html; in my upgrade, I naively updated all uses ofrender texttorender plain, breaking the single use of it that should have beenrender html.That update has now been fixed, and a test case has been added that would have caught the regression.