Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

explicitly include auth helpers in hoc routes test #37626

Merged
merged 1 commit into from Nov 3, 2020
Merged

explicitly include auth helpers in hoc routes test #37626

merged 1 commit into from Nov 3, 2020

Conversation

Hamms
Copy link
Contributor

@Hamms Hamms commented Nov 3, 2020

So it can be run in isolation

Testing story

Ran the test manually in isolation, confirmed that it works now!

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@Hamms Hamms merged commit 36addea into staging Nov 3, 2020
@Hamms Hamms deleted the include-auth-helpers branch November 3, 2020 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davidsbailey davidsbailey davidsbailey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Hamms @davidsbailey