Format resource name in FindResourceDialog to include type and audience #37636
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmcavoy
reviewed
Nov 3, 2020
| if (resource.properties.type) { | ||
| formattedName += ` - ${resource.properties.type}`; | ||
| } | ||
| if (resource.properties.audience) { |
There was a problem hiding this comment.
Did they request to have it include audience too? I think it was just type
There was a problem hiding this comment.
No, just type was brought up I think. Do you think I should remove audience? I don't have an opinion either way really -- just thought it might be easier to see audience too
There was a problem hiding this comment.
I think audience makes it long and I don't think its that helpful in this context so I would leave it off until we get asks for it
There was a problem hiding this comment.
okay -- will change. Thanks!
dmcavoy
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came out of the bug bash, as often times multiple resources have the same name.
Links
Testing story
Reviewer Checklist: