Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Google Blockly] Use getGenerator() in all labs #37639

Merged
merged 1 commit into from Nov 3, 2020
Merged

Conversation

ajpal
Copy link
Contributor

@ajpal ajpal commented Nov 3, 2020

This was the only change I needed to make in Flappy-specific code.
getGenerator as defined in the CDO Blockly wrapper is

  blocklyWrapper.getGenerator = function() {
    return blocklyWrapper.Generator.get('JavaScript');
  };

Making this a no-op change while we use CDO Blockly.

Doing this everywhere now will allow us to start poking around at other labs with Google Blockly and see what works/what breaks.
For example, I loaded a very simple Maze level and it at least renders correctly:
image

Links

Testing story

Relying on existing tests

Reviewer Checklist:

  • Tests provide adequate coverage
  • Privacy and Security impacts have been assessed
  • Code is well-commented
  • New features are translatable or updates will not break translations
  • Relevant documentation has been added or updated
  • User impact is well-understood and desirable
  • Pull Request is labeled appropriately
  • Follow-up work items (including potential tech debt) are tracked and linked

@ajpal ajpal requested a review from a team November 3, 2020 16:38
@ajpal ajpal merged commit eae407b into staging Nov 3, 2020
@ajpal ajpal deleted the nov3-getGenerator branch November 3, 2020 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants