Script Edit Page: Add confirmation dialog when deleting lesson #37649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidsbailey
approved these changes
Nov 3, 2020
|
|
||
| render() { | ||
| const {lessonName, handleClose, lessonPosToRemove} = this.props; | ||
| let bodyText = `Are you sure you want to remove the level named "${lessonName}" from the script?`; |
There was a problem hiding this comment.
Sorry to nit, but there is a lot at stake if the user sees this warning, soI think this could benefit from a stronger warning message, like:
big warning: "Are you sure you want to permanently delete the lesson named X and all its contents?"
optional smaller text: "This will delete any details within the lesson, such as level progressions and lesson plan markdown. Individual levels will not be deleted."
There was a problem hiding this comment.
@davidsbailey how is this?
bethanyaconnor
approved these changes
Nov 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bethany pointed out during the bug bash that we did not have a confirmation dialog on the delete of a lesson on the script edit page. This adds a dialog to confirm you want to delete the lesson.
Links
Testing story
Added a test for the new dialog.
Reviewer Checklist: